POTEL 55 - Fix startChild for span that is not in current OTel Context#3862
Merged
POTEL 55 - Fix startChild for span that is not in current OTel Context#3862
startChild for span that is not in current OTel Context#3862Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 55 - Fix `startChild` for span that is not in current OTel `Context` ([#3862](https://github.com/getsentry/sentry-java/pull/3862))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
OtelSpanFactorynow sets theOtelSpanWrappers underlying OTel span as current span in theContextused when creating a new child span so theContextthat arrives in the span processor has the correct parent set.💡 Motivation and Context
Starting a child span from a transaction that wasn't in the current
Contextlead to multiple transactions being created (one for the transaction and another per span created).💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps