Close Scopes before replacing options on global Scope#3750
Merged
Conversation
…d sentry-graphql-core
…ryInstrumentation bean if missing
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e12b4d2 | 456.29 ms | 543.46 ms | 87.17 ms |
| a121565 | 474.11 ms | 543.36 ms | 69.25 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e12b4d2 | 1.70 MiB | 2.35 MiB | 669.05 KiB |
| a121565 | 1.70 MiB | 2.35 MiB | 669.05 KiB |
An error occurred while trying to automatically change base from
feat/spring-support-graphql-v22
to
8.x.x
October 7, 2024 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Change order of replacing options on global scope and closing previous
Scopes.💡 Motivation and Context
When re-initializing the SDK, it called
closeon integrations, profiler etc. that are supposed to be used after the second call toSentry.initinstead of the ones from first call to init.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps