Conversation
…d sentry-graphql-core
…ryInstrumentation bean if missing
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Replace `GraphQlSourceBuilderCustomizer` with directly providing a `SentryInstrumenter` bean if missing ([#3744](https://github.com/getsentry/sentry-java/pull/3744))If none of the above apply, you can opt out of this check by adding |
adinauer
commented
Oct 4, 2024
|
|
||
| @Bean | ||
| @Bean(name = "sentryInstrumentation") | ||
| @ConditionalOnMissingBean(name = "sentryInstrumentation") |
Member
Author
There was a problem hiding this comment.
We should change this to not rely on the bean name but rather the type SentryInstrumentation regardless of name.
lbloder
reviewed
Oct 4, 2024
Collaborator
lbloder
left a comment
There was a problem hiding this comment.
LGTM 👍, after the @ConditionalOnMissingBean() annotations have been changed to rely on type instead of name
Contributor
Performance metrics 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
We now provide a
SentryInstrumenterbean directly if there is none yet instead of usingGraphQlSourceBuilderCustomizerto add the instrumentation.It is now also possible to provide a bean of type
SentryGraphqlInstrumentation.BeforeSpanCallbackwhich is then used bySentryInstrumenter, e.g.:💡 Motivation and Context
Closes #3412
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps