Skip to content

Add support for v22 of graphql-java via sentry-graphql-22#3740

Merged
adinauer merged 8 commits into8.x.xfrom
fix/support-graphql-v22
Oct 7, 2024
Merged

Add support for v22 of graphql-java via sentry-graphql-22#3740
adinauer merged 8 commits into8.x.xfrom
fix/support-graphql-v22

Conversation

@adinauer
Copy link
Copy Markdown
Member

@adinauer adinauer commented Oct 2, 2024 •
edited
Loading

📜 Description

  • Introduce sentry-graphql-22 to support v22 of graphql-java
    • Please note the different package for SentryInstrumenter for v22: io.sentry.graphql22.SentryInstrumentation
  • Both sentry-graphql and sentry-graphql-22 use sentry-graphql-core
  • BeforeSpanCallback on SentryInstrumenter has been deprecated, the one from SentryGraphqlInstrumentation should be used instead

💡 Motivation and Context

Pt. 1 of fixing #3737

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

  • Auto install should install sentry-graphql-22 instead of sentry-graphql depending on version of graphql-java
  • docs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 455.43 ms 465.00 ms 9.57 ms
Size 1.70 MiB 2.35 MiB 669.06 KiB

Previous results on branch: fix/support-graphql-v22

Startup times

Revision Plain With Sentry Diff
c5005be 400.04 ms 490.84 ms 90.80 ms

App size

Revision Plain With Sentry Diff
c5005be 1.70 MiB 2.35 MiB 669.06 KiB

Base automatically changed from feat/spring-request-body-form to 8.x.x October 4, 2024 08:55
lbloder
lbloder reviewed Oct 4, 2024
View reviewed changes
lbloder
lbloder approved these changes Oct 7, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit 18da8f8 into 8.x.x Oct 7, 2024
@adinauer adinauer deleted the fix/support-graphql-v22 branch October 7, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adinauer @lbloder