Attach request body for application/x-www-form-urlencoded requests in Spring#3731
Merged
Attach request body for application/x-www-form-urlencoded requests in Spring#3731
application/x-www-form-urlencoded requests in Spring#3731Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
lbloder
reviewed
Sep 30, 2024
Collaborator
lbloder
left a comment
There was a problem hiding this comment.
LGTM codewise.
We could extend the SentrySpringFilterTest.caches request depending on the maxRequestBodySize value and request body length to include the new mimetype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #3656
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps