Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #865 +/- ##
==========================================
+ Coverage 83.01% 83.21% +0.20%
==========================================
Files 51 54 +3
Lines 5433 5756 +323
==========================================
+ Hits 4510 4790 +280
- Misses 767 804 +37
- Partials 156 162 +6 ☔ View full report in Codecov by Sentry. |
|
@cleptric Just realised we can't use 1.18 with exp/slog (requires at least 1.19): golang/go#57113 |
|
Yes. We're holding off merging new features for a week or so to give us time to fix potential issues in 0.29.0. Afterwards, we'll get this out. |
cleptric
left a comment
There was a problem hiding this comment.
Let's make this it's own package. You can update https://github.com/getsentry/sentry-go/blob/master/.craft.yml and I'll add it to our release registry.
I updated .craft.yml and made |
|
Just CI needs to pass and then we can get this merged 🙂 |
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
|
@cleptric Shall I update the |
|
Waiting for #898 to be merged before I merge this. |
| return output | ||
| } | ||
|
|
||
| func valueToString(v slog.Value) string { |
There was a problem hiding this comment.
I'm just wondering: why not use https://pkg.go.dev/log/slog#Value.String ?
Resolves #527