Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
==========================================
+ Coverage 81.76% 81.98% +0.22%
==========================================
Files 50 51 +1
Lines 4436 4507 +71
==========================================
+ Hits 3627 3695 +68
- Misses 661 663 +2
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
The only difference between this (and previous incomplete Wrapper) and Chi's is that this defaults to 200 instead of 0 if WriteHeader has not yet been called. |
cleptric
approved these changes
May 28, 2024
|
Is this fix working transparently? or requires some extra initialization? |
Collaborator
Author
|
I just checked and it seems you're right, I've updated the implementation for stdlib but not for negroni. I'll submit a fix today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #836
Was able to reproduce it with 0.28.0 (
Error accepting websocket connection: failed to accept WebSocket connection: http.ResponseWriter does not implement http.Hijacker) and see it resolved with this fix.