fix(fasthttp,fiber): correctly capture request body on scope#1284
Merged
Conversation
These integrations don't re-read r.Body, so the io.TeeReader trick in SetRequest is never used. SetRequestBody is required to capture the body. This changes behavior to drop the redundant r.Body wiring in convert() (which sets a TeeReader that immediately gets overwritten by SetRequestBody) and copies the bytes via bytes.Clone, since fasthttp recycles the body buffer between requests.
Litarnus
approved these changes
Apr 27, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These integrations don't re-read r.Body, so the io.TeeReader trick in SetRequest is never used. SetRequestBody is required to capture the body. This changes behavior to drop the redundant r.Body wiring in convert() (which sets a TeeReader that immediately gets overwritten by SetRequestBody) and copies the bytes via bytes.Clone, since fasthttp recycles the body buffer between requests.
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)Changelog Entry