feat: add support for homogenous arrays#1203
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Ai
Deps
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| // AsBoolSlice returns the []bool value. Make sure that the Value's type is | ||
| // BOOLSLICE. | ||
| func (v Value) AsBoolSlice() []bool { |
There was a problem hiding this comment.
nit: I was thinking if it makes sense to return an error instead of nil for those methods instead. But it might be too noisy for the benefit it would bring
There was a problem hiding this comment.
We don't return an error on the other AsX methods, so I don't think it makes sense to add it only here. Also use case wise:
- if we want just the value
AsInterfaceis the one to use. - and if we want the type for modifying the value then, we have to use
v.Type()anyways.
Description
Add support for scalar slices on the attribute API. We also need to modify the log_entry to extend it to support the new methods as well.
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)