Skip to content

add missing rate limit categories#1082

Merged
giortzisg merged 5 commits intomasterfrom
fix/rate-limits
Sep 15, 2025
Merged

add missing rate limit categories#1082
giortzisg merged 5 commits intomasterfrom
fix/rate-limits

Conversation

@giortzisg
Copy link
Contributor

@giortzisg giortzisg commented Sep 11, 2025

Closes #1081.
Properly handle rate limits by:

  • Add missing types for Logs and CheckIns.
  • Add CategoryUnknown to enum for debugging purposes. Unknown categories should not get rate limited.
  • Tidy: move category transformation to Event.

@giortzisg giortzisg requested a review from cleptric September 11, 2025 08:45
@giortzisg giortzisg self-assigned this Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (54a69e0) to head (2ba5b5c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
- Coverage   86.90%   86.89%   -0.02%     
==========================================
  Files          55       56       +1     
  Lines        6011     6027      +16     
==========================================
+ Hits         5224     5237      +13     
- Misses        643      645       +2     
- Partials      144      145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cleptric cleptric added the Bug Issue type label Sep 12, 2025
interfaces.go Outdated
return json.Marshal(checkIn)
}

func (e *Event) ToCategory() ratelimit.Category {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need to export this, only used in transport.go.

@giortzisg giortzisg merged commit a43141f into master Sep 15, 2025
18 checks passed
@giortzisg giortzisg deleted the fix/rate-limits branch September 15, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Issue type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rate limit for logs

2 participants