Skip to content

Fix: symlinks in normalized upload#2744

Merged
noahsmartin merged 2 commits intomasterfrom
fixSymlinkNormalize
Sep 16, 2025
Merged

Fix: symlinks in normalized upload#2744
noahsmartin merged 2 commits intomasterfrom
fixSymlinkNormalize

Conversation

@noahsmartin
Copy link
Copy Markdown
Contributor

@noahsmartin noahsmartin commented Sep 12, 2025 •
edited by szokeasaurusrex
Loading

Sometimes uploads have symlinks in them, we need to preserve the contents of the upload, otherwise the code signature breaks. Additionally, the app size would change if we changed the contents, making our size analysis invalid

Closes EME-266

@noahsmartin noahsmartin marked this pull request as ready for review September 12, 2025 13:55
@noahsmartin noahsmartin requested review from a team and szokeasaurusrex as code owners September 12, 2025 13:55
szokeasaurusrex
szokeasaurusrex reviewed Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions and comments.

Also, is there an issue for this PR? If yes, I would appreciate if you could link it, so I have the full context

@noahsmartin
Copy link
Copy Markdown
Contributor Author

noahsmartin commented Sep 15, 2025

Thanks @szokeasaurusrex I updated the description a bit and added the linked issue (credit to @chromy for finding it)

@linear
Copy link
Copy Markdown

linear bot commented Sep 16, 2025

EME-266 `sentry-cli` not handling symlinks properly when zipping

@szokeasaurusrex
Copy link
Copy Markdown
Member

szokeasaurusrex commented Sep 16, 2025 •
edited
Loading

I updated the description a bit and added the linked issue (credit to @chromy for finding it)

@noahsmartin FYI to properly link a linear issue, you need to put "Closes" in front of the issue number ("fixes" or "resolves" might also work). I already made the change on this issue. That way, the PR is linked from the Linear issue page, and the Linear issue gets auto-closed when you mere the PR 🙂

If you just put the link, it appears the issue does not get linked to the PR

@noahsmartin noahsmartin merged commit 0a89b3d into master Sep 16, 2025
25 checks passed
@noahsmartin noahsmartin deleted the fixSymlinkNormalize branch September 16, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chromy chromy chromy left review comments

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noahsmartin @szokeasaurusrex @chromy