feat(sourcemaps): Multi-project sourcemaps upload#2497
Merged
szokeasaurusrex merged 1 commit intomasterfrom May 8, 2025
Merged
feat(sourcemaps): Multi-project sourcemaps upload#2497szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces multi‐project support for sourcemaps uploads by allowing repeated use of the –project flag on the CLI. Key changes include updating the UploadContext to use a projects slice, modifying API calls to accept multiple projects, and adjusting legacy upload and command modules to work with this new interface.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/utils/sourcemaps.rs | Updated deduplication logic to extract a single project when applicable and ensure release is provided. |
| src/utils/file_upload.rs | Replaced the single "project" with "projects" and updated legacy upload error handling. |
| src/api/mod.rs | Updated API signatures and doc comments to accept slices for projects. |
| src/commands/* | Adjusted command execution code to retrieve and pass multi‐project configuration. |
loewenheim
reviewed
May 7, 2025
Contributor
loewenheim
left a comment
There was a problem hiding this comment.
Looks good except for some nits. Have you tested it?
e7dfc50 to
2669216
Compare
8700f95 to
5b8e333
Compare
2669216 to
813fa81
Compare
5b8e333 to
2158289
Compare
Member
Author
|
Hey @loewenheim, I have tested this. As an example, see the following artifact bundle, which I uploaded with |
2158289 to
6c01bae
Compare
1bb1afc to
f540dc1
Compare
Base automatically changed from
szokeasaurusrex/chunked-artifact-request-slice
to
master
May 8, 2025 11:52
6c01bae to
2c4b144
Compare
It is now possible to upload sourcemaps to multiple projects at once, by passing the `-p`/`--project` flag multiple times to the `sentry-cli sourcemaps upload` command. Previously, it was possible to specify multiple projects via this flag, but all but the first project were ignored. Multi-project sourcemaps uploads only work for Sentry servers which support chunked uploads – since this feature was added quite some time ago, we expect most self-hosted Sentry instances will support this. Older versions of Sentry continue to only support single-project uploads, but now, instead of silently ignoring all but the first project, an error is returned. Closes #2408
2c4b144 to
dbf29b1
Compare
loewenheim
approved these changes
May 8, 2025
| let project = match projects { | ||
| [] => None, | ||
| [project] => Some(project.as_str()), | ||
| [_, _, ..] => Err(LegacyUploadContextError::ProjectMultiple)?, |
Contributor
There was a problem hiding this comment.
This pattern could also be _ but actually makes sense this way, because it clarifies that the list has at least two elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now possible to upload sourcemaps to multiple projects at once, by passing the
-p/--projectflag multiple times to thesentry-cli sourcemaps uploadcommand. Previously, it was possible to specify multiple projects via this flag, but all but the first project were ignored.Multi-project sourcemaps uploads only work for Sentry servers which support chunked uploads – since this feature was added quite some time ago, we expect most self-hosted Sentry instances will support this. Older versions of Sentry continue to only support single-project uploads, but now, instead of silently ignoring all but the first project, an error is returned.
Closes #2408