build(macos): Sign macOS binaries#2401
Merged
szokeasaurusrex merged 17 commits intomasterfrom Mar 19, 2025
Merged
Conversation
6e1650f to
4549c90
Compare
4549c90 to
e33d3ac
Compare
BYK
approved these changes
Feb 21, 2025
Member
BYK
left a comment
There was a problem hiding this comment.
I think this looks pretty great!
It might be worth adding a smoke test after signing and notarization that just runs the binary and makes sure it doesn't exit with a non-zero code.
mdtro
reviewed
Mar 4, 2025
Co-authored-by: Burak Yigit Kaya <byk@sentry.io>
BYK
approved these changes
Mar 19, 2025
| APPLE_API_KEY_PATH: /tmp/apple_key.json | ||
|
|
||
| steps: | ||
| - name: Checkout repository |
Member
There was a problem hiding this comment.
Don't think you need a check out as you're not using anything from the repo?
I see that we use entitlements from the repo. Not sure how long this step takes but if it's longer than a few seconds we can upload entitlements file along with the artifacts and skip this step.
Member
Author
There was a problem hiding this comment.
I don't think it takes that long – the waiting for notarization I think takes quite a bit longer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1882