Fix ensure authenticated API is only requested when no_upload flag is not present#2047
Merged
szokeasaurusrex merged 2 commits intomasterfrom Apr 30, 2024
Merged
Conversation
szokeasaurusrex
approved these changes
Apr 30, 2024
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good! Adding a test might be nice, but probably not required urgently
szokeasaurusrex
approved these changes
Apr 30, 2024
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Took me a moment to understand what you did with the test code, but I think this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2046
The
upload-proguardcommand has a--no-uploadflag for dry runs. We fetch an authenticated API ahead of time, causing this command to fail, even when--no-uploadis present.I simply re-ordered the logic as a quick fix. Maybe someone more fluent in rust can write a suitable test for this.