Skip to content

Add clarifying comment to RN sourcemaps upload test#1965

Merged
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/clarify-rn-test
Mar 4, 2024
Merged

Add clarifying comment to RN sourcemaps upload test#1965
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/clarify-rn-test

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

The desired behavior of the command being tested is different from what the test specifies. This PR adds a comment to clarify the situation.

Ref #1963

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) March 4, 2024 09:19
@szokeasaurusrex szokeasaurusrex self-assigned this Mar 4, 2024
Copy link
Copy Markdown
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@szokeasaurusrex szokeasaurusrex merged commit a1fb39a into master Mar 4, 2024
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/clarify-rn-test branch March 4, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants