fix(xcode): Only parse Plist when required during RN source maps upload#1940
Merged
szokeasaurusrex merged 7 commits intomasterfrom Feb 28, 2024
Merged
Conversation
added 2 commits
February 12, 2024 15:33
szokeasaurusrex
requested changes
Feb 12, 2024
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Thank you for switching to a match statement; the logic is much clearer to me know, and I was able to identify a way we can simplify the match statement even further. Once you address the suggestion, I am ready to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
32924, expected a string") #1936If users use debug IDs and auto-release reading is disabled, we don't have to read and part Info.plist.
The same applies when users use ENV to set release and dist