Add "--environment" option to "monitors run" (supplement "-e" shorthand)#1881
Merged
szokeasaurusrex merged 2 commits intogetsentry:masterfrom Jan 22, 2024
Merged
Conversation
There is `-e` option in `sentry-cli monitors run` already. This commit supplements it with a more explicit, non-shorthand name.
szokeasaurusrex
approved these changes
Jan 22, 2024
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good! I added a test for your changes and updated an existing test to reflect the new argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is
-eoption insentry-cli monitors run, which allows to pass environment name. However, it was missing any non-shorthand variant. This pull request fixes this inconsistency by adding--environmentas an alternative name for this option.Rationale
Some people prefer full option names for their explicitness, especially when writing scripts. All the other shorthand options for
monitors run, i.e.-sand-h, have their non-shorthand variants, i.e.--scheduleand--help, respectively.