Improve sourcemaps resolve command output#1880
Merged
szokeasaurusrex merged 2 commits intomasterfrom Jan 5, 2024
Merged
Conversation
Swatinem
approved these changes
Jan 5, 2024
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
🎉 1-based offsets is so much better
If you want to be even fancier, you could use so colors/format to bold the numbers or something, but I believe things are already much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two improvements to the
sourcemaps resolvecommand output:Example
To demonstrate this change, we include an example below to demonstrate how the command output has changed. We use the sourcemap from the "Steps to Reproduce" in #1863 (comment).
Example command
Old output
New output
Fixes GH-1863