fix(hybrid-cloud): Adds region fan-out to organizations list command#1860
Merged
GabeVillalobos merged 9 commits intomasterfrom Dec 12, 2023
Merged
fix(hybrid-cloud): Adds region fan-out to organizations list command#1860GabeVillalobos merged 9 commits intomasterfrom
GabeVillalobos merged 9 commits intomasterfrom
Conversation
markstory
reviewed
Dec 6, 2023
Member
Author
|
It isn't super easy to test the fan-out ability without kicking up another mockito server and changing some of the mocking behavior, so I just updated existing testing to hit the mock server. I'm open to feedback on whether this coverage is worth pursuing. |
markstory
approved these changes
Dec 7, 2023
Member
markstory
left a comment
There was a problem hiding this comment.
Looks good to me from a hybrid cloud compatibility point of view, but I'm no rust expert.
dashed
approved these changes
Dec 8, 2023
dashed
reviewed
Dec 8, 2023
dashed
approved these changes
Dec 8, 2023
loewenheim
approved these changes
Dec 12, 2023
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
organization listcommand currently relies on the basehttps://sentry.io/api/0/organizations/route to query the user's active organizations; however, this will stop working when we incorporate multiple regions.In order to address this, we've added logic to query an active user's regions, then fan-out to each of the individual regions in order to query all active organizations. This list is then combined and sorted by name as per usual.
In order to make this change, some of the underlying URI and request construction code had to be modified to allow overriding the request hostname with the region's hostname.