feat(snapshots): Add snapshot upload task by runningcode · Pull Request #1091 · getsentry/sentry-android-gradle-plugin

runningcode · 2026-03-03T10:21:18Z

Context this is just the first version of the feature for BYO snapshots where customers already generate their own snapshots through another framework. This allows them to upload the snapshot folder directory to us.

Summary

Adds a new sentryUploadSnapshots task that invokes sentry-cli build snapshots --app-id <APP_ID> <path> to upload snapshots to Sentry
Adds a sentry.snapshots extension block with appId and path properties
Task is registered unconditionally using lazy property wiring

Usage

In your app module's build.gradle.kts:

sentry {
  snapshots {
    appId.set("com.example.myapp")
    path.set(file("path/to/snapshots"))
  }
}

Then run:

./gradlew sentryUploadSnapshots

🤖 Generated with Claude Code

Add a new `sentryUploadSnapshots` task that uploads snapshots to Sentry via `sentry-cli build snapshots`. The task is registered when the user configures a snapshots path via the new `sentry.snapshots` extension block. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-03T10:21:32Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

(snapshots) Add snapshot upload task by runningcode in #1091

Internal Changes 🔧

Deps

Update Android SDK to v8.34.0 by github-actions in #1092
Update CLI to v3.3.0 by github-actions in #1093
Update CLI to v3.2.3 by github-actions in #1090
Bump getsentry/craft from 2.21.7 to 2.23.1 by dependabot in #1088
Bump actions/upload-artifact from 6 to 7 by dependabot in #1087
Bump getsentry/craft from 2.21.4 to 2.21.7 by dependabot in #1085
Update CLI to v3.2.2 by github-actions in #1084
Bump gradle/actions from 5.0.1 to 5.0.2 by dependabot in #1086

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-03-03T10:21:43Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2603da1

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Register the task unconditionally and let the lazy DirectoryProperty handle resolution at execution time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

sentry-cli build snapshots requires --app-id. Add it as a required property on the SnapshotsExtension. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtension.kt

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt

Move all wiring logic into the task's register() method so the plugin call site only passes project, extension, and org/project overrides. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtension.kt

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt

romtsn

LGTM, a couple of minor things though (sentry properties probably needs to be addressed)

Add proper telemetry setup via configureTelemetryNoVariant, wire sentryProperties file, and pass buildEvents and cliExecutable to the register method. Remove unused GradleInternal import. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt

The snapshot upload task has no variant context, so variant needs to be optional when resolving the sentry.properties file path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Telemetry wiring is not needed for the snapshot upload task. Remove the unused buildEvents parameter and the configureTelemetryNoVariant helper function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPropertiesFileProvider.kt

When variant is null (e.g. snapshot uploads), buildTypeName resolves to an empty string, producing nonsensical paths with double separators like src//sentry.properties. Guard buildTypeName-based paths the same way flavorName-based paths are already guarded. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Verify that getPropertiesFilePath with a null variant finds files in the project root and does not search buildType-specific paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

runningcode commented Mar 3, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt Outdated Show resolved Hide resolved

runningcode and others added 2 commits March 3, 2026 17:07

fix(snapshots): Wire telemetry provider for snapshot uploads

ae87b25

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor(snapshots): Remove afterEvaluate and isPresent check

1eec8e8

Register the task unconditionally and let the lazy DirectoryProperty handle resolution at execution time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

runningcode changed the title ~~feat(snapshots): Add snapshot upload task~~ feat(snapshots): Add snapshot upload task (WIP) Mar 3, 2026

feat(snapshots): Add required --app-id argument

ca2fec8

sentry-cli build snapshots requires --app-id. Add it as a required property on the SnapshotsExtension. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

runningcode changed the title ~~feat(snapshots): Add snapshot upload task (WIP)~~ feat(snapshots): Add snapshot upload task Mar 4, 2026

runningcode commented Mar 4, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtension.kt Show resolved Hide resolved

runningcode marked this pull request as ready for review March 4, 2026 07:37

runningcode requested review from adinauer, chromy, lcian, markushi, rbro112 and romtsn as code owners March 4, 2026 07:37

docs: Add changelog entry for snapshot uploads

2e69dd4

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

sentry bot reviewed Mar 4, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt Show resolved Hide resolved

refactor(snapshots): Simplify task registration API

582082e

Move all wiring logic into the task's register() method so the plugin call site only passes project, extension, and org/project overrides. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

runningcode commented Mar 4, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtension.kt Show resolved Hide resolved

runningcode commented Mar 4, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt Outdated Show resolved Hide resolved

style: Apply spotless formatting

cfa4336

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rbro112 approved these changes Mar 5, 2026

View reviewed changes

romtsn reviewed Mar 5, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt Show resolved Hide resolved

romtsn reviewed Mar 5, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt Outdated Show resolved Hide resolved

romtsn approved these changes Mar 5, 2026

View reviewed changes

sentry bot reviewed Mar 5, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt Show resolved Hide resolved

cursor bot reviewed Mar 5, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt Outdated Show resolved Hide resolved

runningcode and others added 2 commits March 5, 2026 15:05

fix(snapshots): Make variant nullable in getPropertiesFilePath

65587af

The snapshot upload task has no variant context, so variant needs to be optional when resolving the sentry.properties file path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor(snapshots): Remove telemetry from snapshot uploads

b298f89

Telemetry wiring is not needed for the snapshot upload task. Remove the unused buildEvents parameter and the configureTelemetryNoVariant helper function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cursor bot reviewed Mar 5, 2026

View reviewed changes

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPropertiesFileProvider.kt Show resolved Hide resolved

runningcode and others added 2 commits March 5, 2026 17:28

test(snapshots): Add tests for null variant property lookup

2603da1

Verify that getPropertiesFilePath with a null variant finds files in the project root and does not search buildType-specific paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

runningcode closed this Mar 6, 2026

runningcode reopened this Mar 6, 2026

runningcode merged commit f74417d into main Mar 6, 2026
25 of 41 checks passed

runningcode deleted the no/snapshot-uploads branch March 6, 2026 08:22

sentry-release-bot bot mentioned this pull request Mar 9, 2026

publish: getsentry/sentry-android-gradle-plugin@6.2.0-alpha.1 getsentry/publish#7385

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(snapshots): Add snapshot upload task#1091

feat(snapshots): Add snapshot upload task#1091
runningcode merged 12 commits intomainfrom
no/snapshot-uploads

runningcode commented Mar 3, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 3, 2026 •

edited

Loading

New Features ✨

Internal Changes 🔧

Deps

Uh oh!

github-actions bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romtsn left a comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

runningcode commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Usage

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Internal Changes 🔧

Deps

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romtsn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

runningcode commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading