Reversed ordering of asSentryCliExec and withSentryTelemetry

Low Severity

The call order of task.withSentryTelemetry() and task.asSentryCliExec() is reversed compared to every other task registration in the codebase (SentryUploadAppArtifactTask, SentryUploadNativeSymbolsTask, BundleSourcesTask, UploadSourceBundleTask). All other tasks call asSentryCliExec() first, then withSentryTelemetry(). Since both methods register doFirst/doLast actions, and Gradle executes doFirst in LIFO and doLast in FIFO order, this swap changes the runtime execution order of telemetry span tracking relative to CLI error handling.

 

probably this is good to align with other tasks, since SentryTelemetryService does some things (e.g. error handling) based on the output of SentryCliException (which is handled in asSentryCliExec), so should probably be reordered

So, this is done inside the isVariantAllowed which means that if you disable sentry for the debug variants then you will need to upload your snapshots with the release variant.
This doesn't pose any problems other than it might be confusing for users.

They will have to do something like this:

afterEvaluate {
tasks.named<SentryUploadSnapshotsTask>("sentryUploadSnapshotsRelease") {
    dependsOn(tasks.named("recordRoborazziDebug"))
    snapshotsPath.set(file("snapshotsDir"))
  }
}

Alternatively, we can move it outside the isVariantAllowed but then we would either not have telemetry or move the telemetry outside the isVariantAllowed.

I think we should do it like this since it is the safest option, we can always move it outside isVariantAllowed if customers complain.

this sounds good -- named should throw if a task with that name does not exist right? So even if they ignored a variant, gradle won't let them wire a non-existing task and would surface this quickly, so hopefully this would resolve the confusion

Bug: The SentryUploadSnapshotsTask will cause a Gradle validation error if the required snapshotsPath property is not explicitly configured by the user, as it's no longer set by default.
_{Severity: MEDIUM}

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadSnapshotsTask.kt#L32-L35

Potential issue: The `snapshotsPath` property in `SentryUploadSnapshotsTask` is declared
as a required `@InputDirectory` but is no longer configured by default from the Sentry
extension. If a user runs a `sentryUploadSnapshots...` task without manually configuring
the `snapshotsPath` for that specific task, the build will fail with a generic Gradle
validation error. This happens because the property is used via `snapshotsPath.get()`
without a prior check, and the missing `@Optional` annotation causes Gradle to enforce
its presence before task execution. The error message from Gradle is not specific to the
Sentry plugin, making it difficult for users to understand that they need to set this
property.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

This is how we expect it to be configured. The task needs to be manually wired now.