fix(gh-pages): add CNAME file to preserve custom domain on deploy#751
Merged
fix(gh-pages): add CNAME file to preserve custom domain on deploy#751
Conversation
The gh-pages target runs `git rm -rf .` before extracting the new archive, which deletes any CNAME file previously on the branch. By placing the CNAME in `docs/public/`, Astro includes it in the build output and it ends up in the gh-pages.zip artifact. This is the same pattern used by getsentry/cli.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/public/CNAMEwithcraft.sentry.devso the custom domain survives gh-pages deploymentsProblem
The gh-pages target runs
git rm -rf .before extracting the new archive, which deletes any CNAME file previously on the branch. This causescraft.sentry.devto stop resolving after each release.Fix
Astro copies everything from
public/into the build output (dist/), which then gets zipped intogh-pages.zip. By placing the CNAME file indocs/public/, it's automatically included in every deployment archive. This is the same pattern used by getsentry/cli.No changes to the gh-pages target code or
.craft.ymlare needed.