fix(ux): show failed check details on status provider failures#756
Merged
fix(ux): show failed check details on status provider failures#756
Conversation
When a CI status check fails during publish, Craft now logs which specific checks failed (with their conclusion and URL) instead of only saying "Build(s) have not succeeded". Also includes a direct link to the commit status page on GitHub. Closes #752
hubertdeng123
approved these changes
Feb 17, 2026
| */ | ||
| protected async getRevisionCheckSuites( | ||
| revision: string | ||
| revision: string, |
Member
There was a problem hiding this comment.
Shouldn't a linter be able to catch all these commas?
Member
Author
There was a problem hiding this comment.
it should be the formatter, I'll check that later
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Pending statuses are not failures — only include conclusively failed ones (consistent with the check runs filter which already checks for completed status).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a CI status check fails during
craft publish, the error message now lists which specific checks failed instead of only saying "Build(s) have not succeeded. Please check the revision's status."Before: Users had to manually query the GitHub API or run with
--log-level="Debug"to find which check failed — especially painful for org-wide checks not visible in the repo's GH UI.After: Failed checks are logged at error level with their name, conclusion, and URL:
Changes
src/status_providers/base.tsgetFailureDetails()hook (default empty);waitForTheBuildToSucceed()logs details before throwingsrc/status_providers/github.tsgetFailureDetails()to list failed statuses/check runs with URLs; excludes pending statuses from failure listsrc/status_providers/__tests__/github.test.tsCloses #752