fix(action): Use action/setup-node instead of unofficial volta action#256
Merged
andreiborza merged 3 commits intomasterfrom Feb 10, 2025
Merged
fix(action): Use action/setup-node instead of unofficial volta action#256andreiborza merged 3 commits intomasterfrom
action/setup-node instead of unofficial volta action#256andreiborza merged 3 commits intomasterfrom
Conversation
c98164b to
4d90098
Compare
4d90098 to
e4d4816
Compare
chargome
approved these changes
Feb 10, 2025
| # setup-node doesn't allow absolute paths, so we can't | ||
| # just use `github.action_path` to read this out from the `package.json` | ||
| # any changes to the runtime need to be reflected here | ||
| node-version: 18.17.0 |
Member
There was a problem hiding this comment.
should we use the latest 18 version?
Member
Author
There was a problem hiding this comment.
I pinned to what's in the package.json. For now I'll keep it like this but will look into bumping this in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action now first checks if node is already installed and if so skips
action/setup-node, otherwise we ensure node (and thus npm) are installed before running the action.Additionally, it also marks the
GITHUB_WORKSPACEas a safe directory for git so the runner can correctly cd into the repo root for automatic release name determination and commit blaming.Closes: #249