Merged
Conversation
04ea06b to
4c03734
Compare
fenollp
reviewed
Jun 16, 2024
fenollp
reviewed
Jun 16, 2024
fenollp
requested changes
Jun 16, 2024
Collaborator
fenollp
left a comment
There was a problem hiding this comment.
Thanks for this (as well!) I only have 2 requests and this needs rebasing. LGTM!
Go 1.18 introduced any which is prefered over interface{},
they are equivalent (type alias).
golang/go@2580d0e
Co-authored-by: Pierre Fenoll <pierrefenoll@gmail.com>
Co-authored-by: Pierre Fenoll <pierrefenoll@gmail.com>
57b5450 to
fe86b5d
Compare
fenollp
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.18 introduced any which is prefered over interface{}, they are equivalent (type alias).
golang/go@2580d0e
The go.mod currently targets Go 1.20+