openapi3gen: skip component export for anonymous types#1163
Merged
Conversation
fenollp
requested changes
May 3, 2026
Anonymous nested struct types have an empty reflect.Type.Name(), so generateTypeName returns "". Registering them under that key produces "#/components/schemas/" refs that violate the OpenAPI spec (component keys must match ^[a-zA-Z0-9._-]+$) and break codegen tools like Orval. Inline the schema instead, matching the existing behavior for generics and time.Time.
0ccd467 to
9cfa6b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
ExportComponentSchemas: trueis set and the generator walks into a struct field whose type is anonymous (e.g. an inlinestruct{...}literal),reflect.Type.Name()returns"". The component-export branch ingenerateSchemaRefForhappily registers it:The result is a component keyed by
""and a\$refof#/components/schemas/. Both violate the OpenAPI 3 component-key pattern (^[a-zA-Z0-9._-]+\$) and downstream codegen tools reject the spec:Fix
When
generateTypeNamereturns"", inline the schema instead of registering it as a component. This matches the behavior already used for generics andtime.Timein the same function.Test
TestExportComponentSchemasSkipsAnonymousTyperegisters a struct with an inline anonymous field and asserts no component schema is created with an empty key.