test: fix expected-actual parameters in require.Equal#1035
Merged
fenollp merged 1 commit intogetkin:masterfrom Nov 26, 2024
Merged
test: fix expected-actual parameters in require.Equal#1035fenollp merged 1 commit intogetkin:masterfrom
fenollp merged 1 commit intogetkin:masterfrom
Conversation
Well, testify v2 is on hold |
|
Thanks for fixing this Dix you use testifylint to detect them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the order of parameters in
assert.Equal/require.Equalstatements. According to the doc, the first parameter isexpected, the second isactual.It is planned to change the order of assertion arguments to more natural
(actual, expected)inv2oftestify.