openapi3filter: Remove redundant ExcludeResponseBody check#1056
Merged
fenollp merged 1 commit intogetkin:masterfrom Mar 10, 2025
tatsumack:fix/remove-redundant-exclude-response-body-check
Merged
openapi3filter: Remove redundant ExcludeResponseBody check#1056fenollp merged 1 commit intogetkin:masterfrom tatsumack:fix/remove-redundant-exclude-response-body-check
fenollp merged 1 commit intogetkin:masterfrom
tatsumack:fix/remove-redundant-exclude-response-body-check
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a redundant condition check in the ValidateResponse function.
Currently, there are two checks for
options.ExcludeResponseBody:The second check is redundant because if
options.ExcludeResponseBodyis true, the function would have already returned at the first check. This PR removes the redundant condition to improve code clarity.