Skip to content

fix(windows): Windows input (paste input) may arrive as UTF-16 still …#987

Merged
gdamore merged 1 commit intov2from
v2-win32-surrogates
Jan 11, 2026
Merged

fix(windows): Windows input (paste input) may arrive as UTF-16 still …#987
gdamore merged 1 commit intov2from
v2-win32-surrogates

Conversation

@gdamore
Copy link
Owner

@gdamore gdamore commented Jan 11, 2026

…(fixes#984)

This also fixes the modifier key mappings. The changes were adapted from the v3 branch.

@gdamore
fix(windows): Windows input (paste input) may arrive as UTF-16 still …
4739cfe 
…(fixes#984)

This also fixes the modifier key mappings. The changes were adapted from the v3
branch.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 11, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.28%. Comparing base (aa43d8f) to head (4739cfe).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
tty_win.go 0.00% 13 Missing ⚠️
input.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               v2     #987      +/-   ##
==========================================
- Coverage   35.41%   35.28%   -0.13%     
==========================================
  Files          75       75              
  Lines        5730     5745      +15     
==========================================
- Hits         2029     2027       -2     
- Misses       3668     3685      +17     
  Partials       33       33
Flag Coverage Δ
unittests 35.28% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gdamore gdamore merged commit 4739cfe into v2 Jan 11, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gdamore