The intention here was to emit only a single OSC spanning multiple cells... we only "close" it when we reach the end of the URL.

I don't think this change is correct.

I looked at the downstream bug. I think the analysis there is probably incorrect.

lazygit never use url so it's always "". (jesseduffield/lazygit#4421 (comment))

So the problem here is exitUrl should only be emited when we have enterUrl.

Done now (forgot to rebase before)

Wait. the logic in windows looks a bit different. I'll look it again

Ok I'm not sure what happened here, on style change: it write last style rather than the current one.

while in tscreen.go it write current style (not the last style).

~So if this is a typo I can correct it but I would guess it's probably not again...
~

EDIT: it's not a typo according the comment.
I cannot figure out a way without using a urlOpen variable. (Otherwise a "last of last style"??

The idea of the "lastStyle" was to ensure that we flush any unwritten changes when changing style. The whole idea is to reduce system call overhead by batching.

What happened to the windows implementation? I'm surprised that this got merged when it still doesn't work on Windows.

@gdamore It looks like the Windows implementation is sufficiently different from tScreen that the same approach of using curstyle isn't easily possible. I briefly looked into making the cScreen implementation more similar to tScreen in this regard, but there are too many things in the code that I don't understand, so I didn't feel comfortable suggesting that.

It looks like for Windows we do have to go with the urlOpen variable approach, unless we totally want to refactor the logic.