Add public methods for UnderlineStyle and UnderlineColor#790
Merged
gdamore merged 2 commits intogdamore:mainfrom Jul 13, 2025
Merged
Add public methods for UnderlineStyle and UnderlineColor#790gdamore merged 2 commits intogdamore:mainfrom
gdamore merged 2 commits intogdamore:mainfrom
Conversation
gdamore
requested changes
Jul 10, 2025
| return s2 | ||
| } | ||
|
|
||
| // UnderlineStyle returns the underline style for the style. |
Owner
There was a problem hiding this comment.
I think I understand the desire here, but these functions do not follow the pattern of other methods in the style. E.g. "Reverse()" returns a modified Style.
Perhaps prefixing their names with "Get" will avoid possible confusion here?
Contributor
Author
There was a problem hiding this comment.
You're absolutely right! I'll update the method names to include the "Get" prefix to follow the existing pattern:
UnderlineStyle()→GetUnderlineStyle()UnderlineColor()→GetUnderlineColor()
Thanks for the feedback!
Rename UnderlineStyle() and UnderlineColor() to GetUnderlineStyle() and GetUnderlineColor() to align with existing Style API patterns.
gdamore
approved these changes
Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #787