Do not filter Ctrl+Alt in non-rune cases#749
Merged
gdamore merged 2 commits intogdamore:mainfrom Aug 23, 2025
Merged
Conversation
Ctrl+Alt seems to be the same as AltGr and AltGr usually switches the keyboard layout to level 3. This is not true for keys combos like: Ctrl + Alt + [Up, Down, Left, Right, Home, End, PageUp, PageDown, Delete, Backspace] or mouse clicks.
Owner
|
So I confess I'm not sure about this. I can see that for some things like your Ctrl-Alt-Up situation, you might prefer to get keystrokes like that. I'm not sure how this should happen with other keystrokes though. I need to research a bit more I guess. |
Contributor
Author
|
No worries and thank you for looking into this! I tested that the level 3 behavior remains as it was before for normal keys. Mouse clicks were also affected by that mentioned commit and now got their mods back. |
Contributor
Author
|
@gdamore What objections are there regarding other keystrokes? I am happy to help. tcell not supporting |
gdamore
approved these changes
Aug 23, 2025
Owner
|
I'm not sure why codeql isn't running. I'm going to merge this manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I am currently trying to add additional keybindings in fzf/pull/3996 and in that process I noticed that there is a bug in tcell where
Ctrl+Altmodifiers are not set correctly under windows.Ctrl+Altseems to be the same as AltGr and AltGr usually switches the keyboard layout to level 3. But this is not true for keys combos like:Ctrl+Altin conjunction withUp,Down,Left,Right,Home,End,Backspace,Delete,PageUp,PageDown.How to reproduce:
Ctrl+Alt+UpCtrl+Alt+UpActual key event:
Up(no mods)The mods
CtrlandAltare being filtered out by commit 96e2990.