Skip to content

Horizontal borders draws wrongly#150

Merged
gajus merged 3 commits intogajus:masterfrom
nam-hle:borders-draws-wrong
Apr 23, 2021
Merged

Horizontal borders draws wrongly#150
gajus merged 3 commits intogajus:masterfrom
nam-hle:borders-draws-wrong

Conversation

@nam-hle
Copy link
Collaborator

@nam-hle nam-hle commented Apr 19, 2021

Fix #123.

@coveralls
Copy link

coveralls commented Apr 19, 2021

Pull Request Test Coverage Report for Build 297

  • 24 of 24 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.788%

Totals Coverage Status
Change from base Build 288: 0.002%
Covered Lines: 352
Relevant Lines: 352

💛 - Coveralls

@nam-hle nam-hle force-pushed the borders-draws-wrong branch from ab29244 to d5f8be5 Compare April 21, 2021 06:16
@gajus gajus merged commit 1b56b29 into gajus:master Apr 23, 2021
@gajus
Copy link
Owner

gajus commented Apr 23, 2021

🎉 This PR is included in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 23, 2021
@nam-hle nam-hle deleted the borders-draws-wrong branch April 24, 2021 00:22
nam-hle added a commit to nam-hle/table that referenced this pull request Apr 24, 2021
* Horizontal borders draws wrongly

* Remove wrong fix

* Remove assertion

Co-authored-by: Nam Hoang Le <nam.hoang.le@mgm-tp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drawHorizontalLine counts lines wrong when used together with overlong lines, wordWrap or truncate

4 participants