feat: whitelist control chars to print hyperlinks in terminal, addresses issue #82 (#93)

tahmidsadik · gajus · commit 29655fed7b21 · 2019-05-09T11:20:49.000+01:00
diff --git a/src/validateTableData.js b/src/validateTableData.js
@@ -36,7 +36,7 @@ export default (rows) => {
 
     for (const cell of cells) {
       // eslint-disable-next-line no-control-regex
-      if (/[\u0001-\u0009\u000B-\u001A]/.test(cell)) {
+      if (/[\u0001-\u0006\u0008-\u0009\u000B-\u001A]/.test(cell)) {
         throw new Error('Table data must not contain control characters.');
       }
     }
diff --git a/test/validateTableData.js b/test/validateTableData.js
@@ -58,6 +58,33 @@ describe('validateTableData', () => {
     });
   });
 
+  context('cell data contains hyperlinks', () => {
+    const OSC = '\u001B]';
+    const BEL = '\u0007';
+    const SEP = ';';
+    const url = 'https://example.com';
+    const text = 'This is a link to example.com';
+
+    const link = [
+      OSC,
+      '8',
+      SEP,
+      SEP,
+      url,
+      BEL,
+      text,
+      OSC,
+      '8',
+      SEP,
+      SEP,
+      BEL
+    ].join('');
+
+    it('does not throw', () => {
+      validateTableData([[link]]);
+    });
+  });
+
   context('rows have inconsistent number of cells', () => {
     it('throws an error', () => {
       expect(() => {

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export default (rows) => {`
`36`	`36`
`37`	`37`	`for (const cell of cells) {`
`38`	`38`	`// eslint-disable-next-line no-control-regex`
`39`		`- if (/[\u0001-\u0009\u000B-\u001A]/.test(cell)) {`
	`39`	`+ if (/[\u0001-\u0006\u0008-\u0009\u000B-\u001A]/.test(cell)) {`
`40`	`40`	`throw new Error('Table data must not contain control characters.');`
`41`	`41`	`}`
`42`	`42`	`}`