fix: accept newlines passed into table data (#89)

rix0rrr · gajus · commit 24516c41c653 · 2019-01-14T14:51:50.000Z
diff --git a/src/validateTableData.js b/src/validateTableData.js
@@ -34,11 +34,9 @@ export default (rows) => {
       throw new Error('Table must have a consistent number of cells.');
     }
 
-    // @todo Make an exception for newline characters.
-    // @see https://github.com/gajus/table/issues/9
     for (const cell of cells) {
       // eslint-disable-next-line no-control-regex
-      if (/[\u0001-\u001A]/.test(cell)) {
+      if (/[\u0001-\u0009\u000B-\u001A]/.test(cell)) {
         throw new Error('Table data must not contain control characters.');
       }
     }
diff --git a/test/validateTableData.js b/test/validateTableData.js
@@ -52,6 +52,12 @@ describe('validateTableData', () => {
     });
   });
 
+  context('cell data contains newlines', () => {
+    it('does not throw', () => {
+      validateTableData([['ab\nc']]);
+    });
+  });
+
   context('rows have inconsistent number of cells', () => {
     it('throws an error', () => {
       expect(() => {

Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,9 @@ export default (rows) => {`
`34`	`34`	`throw new Error('Table must have a consistent number of cells.');`
`35`	`35`	`}`
`36`	`36`
`37`		`- // @todo Make an exception for newline characters.`
`38`		`- // @see https://github.com/gajus/table/issues/9`
`39`	`37`	`for (const cell of cells) {`
`40`	`38`	`// eslint-disable-next-line no-control-regex`
`41`		`- if (/[\u0001-\u001A]/.test(cell)) {`
	`39`	`+ if (/[\u0001-\u0009\u000B-\u001A]/.test(cell)) {`
`42`	`40`	`throw new Error('Table data must not contain control characters.');`
`43`	`41`	`}`
`44`	`42`	`}`