Merged
Conversation
This commit replaces positional field initialization in test cases with named field initialization to improve readability. While at it, also remove tests that were commented out.
This commit renames two test funcs to begin with "must" if they can panic: - hexDecode() -> mustHexDecode() - bigIntOrPanic() -> mustBigInt()
This commit updates the spelling of words containing "marshal" to use just one "l" instead of "ll". For example: - marshalling -> marshaling - marshalled -> marshaled - etc. This spelling change follows the convention used by Go.
Owner
Author
|
@x448 PTAL 🙏 There were no coding changes to non-test files. |
x448
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors tests:
Replace positional field initialization in test cases with named field initialization (to improve readability).
Remove commented out tests.
Modernize by using
fmt.Appendf.Rename two test funcs that can panic:
hexDecode()->mustHexDecode()bigIntOrPanic()->mustBigInt()Update comments to use one "l" in "marshal*", such as "marshalling" -> "marshaling" (to use same spelling as Go).
NOTE: Some non-test files were also updated but those are limited to spelling change in comments.