Merged
Conversation
This commit is only relevant for user apps that use the non-default DupMapKeyEnforcedAPF decoding option. Currently, DupMapKeyError uses hardcoded quotes in the error message for map keys, including non-string types. Given this, an error message containing a quoted integer having a value of 1 looks the same as the string "1" because they both have quotes in the error message. This commit removes the hardcoded quotes in the error message and replaces %v with %#v to only emit quotes when applicable.
Owner
Author
|
@x448 PTAL 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
DupMapKeyErroruses hard-coded quotes in the error message for map keys, including non-string types.Given this, an error message containing a quoted integer having a value of 1 looks the same as the string "1" because they both have quotes in the error message.
This PR removes the hard-coded quotes in the error message and replaces
%vwith%#vto only emit quotes when applicable.NOTE: This change is only relevant for user apps that use the non-default
DupMapKeyEnforcedAPFdecoding option.