kqueue: skip ENOENT entries in watchDirectoryFiles#748
Merged
mattn merged 2 commits intoApr 27, 2026
Conversation
watchDirectoryFiles only suppressed EACCES/EPERM from internalWatch. A dangling symlink in the watched directory caused unix.Open to follow the link and fail with ENOENT, aborting Watcher.Add for the whole directory. Treat os.ErrNotExist the same as a permission error: mark the entry as seen and continue. Regression from fsnotify#681.
The dragonfly carve-out was copied from create-unresolvable-symlink, which creates the dangling symlink after the watch starts and dragonfly does not deliver an event for that path. bug-727 is the inverse: the dangling symlink already exists when Add() is called, and the post-watch event is for a separate file (touch /after). dragonfly produces the expected CREATE event in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #727. On kqueue,
Watcher.Addon a directory containing a dangling symlink failed becausewatchDirectoryFilesonly swallowedEACCES/EPERMfrominternalWatch. Whenunix.Open(O_EVTONLY)followed a symlink to a missing target it returnedENOENT, which propagated up and aborted the wholeAdd. Addos.ErrNotExistto the same skip path so the entry is marked as seen and watching continues for the rest of the directory. Regression from #681. Adds a regression test undertestdata/watch-dir/bug-727.