Improve inotify initialization error message#731
Merged
Conversation
mattn
approved these changes
Apr 21, 2026
Contributor
|
@shawnhuang92 Could you please rebase master branch? |
5a37846 to
d15fb2b
Compare
Contributor
Author
@mattn Rebased and updated. Thanks! |
Contributor
|
LGTM |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the error message when inotify initialization fails in newBackend().
Motivation
fsnotifyis used by Kubernetes. Previously, when inotify init failed, the error lacked context:This made it hard to identify the root cause.
After This PR
Benefits