Conversation
People are running in to trouble because the 4K buffer can overflow; see: #72. This is not a "real" fix, but I think a 64K buffer is acceptable even on memory-limited machines; no one is running the Windows on an Arduino, and even with something like 128M of memory, the extra 124K is basically negligible. There is also no real performance difference between allocating a large array vs. a small array: they're both comparable. It should probably be enough for most applications. Need to look in the future to either dynamically grow the size, or allow setting it similar to what tilt does as mentioned in #72.
nshalman
approved these changes
Aug 4, 2022
Contributor
nshalman
left a comment
There was a problem hiding this comment.
Seems reasonable to me, with the caveat that I don't have deep insight into Windows.
Member
Author
Yeah, me neither, but tilt has been running a fork of this with a 64k buffer size for over two years, so it's actually fairly well tested. |
This was referenced Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People are running in to trouble because the 4K buffer can overflow;
see: #72.
This is not a "real" fix, but I think a 64K buffer is acceptable even on
memory-limited machines; no one is running the Windows on an Arduino,
and even with something like 128M of memory, the extra 124K is basically
negligible. There is also no real performance difference between
allocating a large array vs. a small array: they're both comparable.
It should probably be enough for most applications. Need to look in the
future to either dynamically grow the size, or allow setting it similar
to what tilt does as mentioned in #72.