Skip to content

Document and test removing watched directory on Windows#589

Merged
arp242 merged 1 commit intomainfrom
win-rm
Oct 19, 2023
Merged

Document and test removing watched directory on Windows#589
arp242 merged 1 commit intomainfrom
win-rm

Conversation

@arp242
Copy link
Copy Markdown
Member

@arp242 arp242 commented Oct 19, 2023

On Windows deleting the watched directive gives undefined results and delivering events for the files in the directory is not guaranteed. I can reproduce this even with a very simple example in Python, and it's not an fsnotify bug as far as I can see.

There's nothing we can do about this, so update the documentation and tweak the test so we don't get intermittent test failures.

On other platforms it does report all files.

On Windows deleting the watched directive gives undefined results and
delivering events for the files in the directory is not guaranteed. I
can reproduce this even with a very simple example in Python, and it's
not an fsnotify bug as far as I can see.

There's nothing we can do about this, so update the documentation and
tweak the test so we don't get intermittent test failures.

On other platforms it does report all files.
@arp242 arp242 merged commit e545940 into main Oct 19, 2023
@arp242 arp242 deleted the win-rm branch October 19, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant