Skip to content

fix: correct LinkRefDef line break handling​#230

Merged
frostming merged 1 commit into
frostming:masterfrom
iyanging:master
Jun 13, 2025
Merged

fix: correct LinkRefDef line break handling​#230
frostming merged 1 commit into
frostming:masterfrom
iyanging:master

Conversation

@iyanging

Copy link
Copy Markdown
Contributor

'[foo]: /url "title" ok', without \n, should not be recognized as a LinkRefDef

@frostming

Copy link
Copy Markdown
Owner

Thanks, can you add a test case for it?

@iyanging

iyanging commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, can you add a test case for it?

Is there a suitable test file / class for this?
Done !

@frostming

Copy link
Copy Markdown
Owner

Thanks, can you add a test case for it?

Is there a suitable test file / class for this?

you can add it this list

marko/tests/test_spec.py

Lines 67 to 73 in b65bc85

COMMON_CASES = [
(
"mixed_tab_space_in_list_item",
"* foo\n\t* foo.bar",
"<ul><li>foo<ul><li>foo.bar</li></ul></li></ul>",
)
]

'[foo]: /url "title" ok', without \n, should not be recognized as a LinkRefDef
@iyanging iyanging changed the title fix: correct LinkRefDef line ending handling​ fix: correct LinkRefDef line break handling​ Jun 13, 2025
@frostming frostming merged commit 508e202 into frostming:master Jun 13, 2025
19 checks passed
@iyanging

Copy link
Copy Markdown
Contributor Author

Is there any schedule for a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants