Skip to content

Attach ctx#50

Merged
NSEcho merged 4 commits intofrida:mainfrom
dylanhitt:AttachCtx
Oct 15, 2024
Merged

Attach ctx#50
NSEcho merged 4 commits intofrida:mainfrom
dylanhitt:AttachCtx

Conversation

@dylanhitt
Copy link
Copy Markdown
Contributor

Took a pass at the utility function of handleCtx to limit some of the boiler plate. Let me know what you think.

@dylanhitt dylanhitt changed the title Attach ctx Draft: Attach ctx Oct 4, 2024
@dylanhitt dylanhitt changed the title Draft: Attach ctx Attach ctx Oct 4, 2024
@dylanhitt
Copy link
Copy Markdown
Contributor Author

@NSEcho Any thoughts on the above

@NSEcho
Copy link
Copy Markdown
Member

NSEcho commented Oct 11, 2024

Hey @dylanhitt, I didn't have much time to take a look at this, I will get to it over the weekend.

@NSEcho
Copy link
Copy Markdown
Member

NSEcho commented Oct 12, 2024

Hi @dylanhitt, could you please instead of ParamsCtx use ParamsWithContext convention throughout the code, otherwise looking okay

@dylanhitt
Copy link
Copy Markdown
Contributor Author

Sure I'll get to it tomorrow.

@dylanhitt
Copy link
Copy Markdown
Contributor Author

I think that should do it.

Thank you

@dylanhitt dylanhitt mentioned this pull request Oct 15, 2024
@NSEcho
Copy link
Copy Markdown
Member

NSEcho commented Oct 15, 2024

Thanks @dylanhitt

@NSEcho NSEcho merged commit 2b9405d into frida:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants