Use the powershell activate script on windows#13
Conversation
|
I will test this first and report here. |
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
6d6134b to
1366d05
Compare
|
This version works, tested here: https://github.com/shsms/frequenz-microgrid-component-graph-python/actions/runs/19504402333 |
llucax
left a comment
There was a problem hiding this comment.
Approving in case you don't want to go through another round of testing, I think it is OK to keep it as it is, but the alternative approach I suggest would make the pipeline less noisy, as we don't get a few skipped jobs.
Also at some point it would probably be nice to add some sort of CI, but I guess it doesn't happen often that we need changes for this...
| if: runner.os != 'Windows' | ||
| shell: bash | ||
| env: | ||
| NOX_SESSION: ${{ inputs.nox-session }} |
There was a problem hiding this comment.
| NOX_SESSION: ${{ inputs.nox-session }} | |
| ACTIVATE_SCRIPT: ${{ runner.os == 'Windows' && 'Scripts/Activate.ps1' || `bin/activate` }} |
| env: | ||
| NOX_SESSION: ${{ inputs.nox-session }} | ||
| run: | | ||
| . ".nox/$NOX_SESSION/bin/activate" |
There was a problem hiding this comment.
| . ".nox/$NOX_SESSION/$ACTIVATE_SCRIPT" |
| - name: Print pip freeze for nox venv (debug) (Windows) | ||
| if: runner.os == 'Windows' | ||
| shell: pwsh | ||
| env: | ||
| NOX_SESSION: ${{ inputs.nox-session }} | ||
| run: | | ||
| . ".nox/$env:NOX_SESSION/Scripts/Activate.ps1" | ||
| pip freeze | ||
|
|
There was a problem hiding this comment.
| - name: Print pip freeze for nox venv (debug) (Windows) | |
| if: runner.os == 'Windows' | |
| shell: pwsh | |
| env: | |
| NOX_SESSION: ${{ inputs.nox-session }} | |
| run: | | |
| . ".nox/$env:NOX_SESSION/Scripts/Activate.ps1" | |
| pip freeze |
|
That won't be enough, because on windows, that script is for PowerShell. So it would need more conditional checks and more trial and error. Would leave for later. |
|
Release as v1.1 or v2? |
Also, they are steps in a job, not jobs themselves. And I didn't see any skipped logs. |
|
v1.1, there are no breaking changes |
No description provided.