Improve workflows security#546
Merged
llucax merged 10 commits intofrequenz-floss:v0.x.xfrom Mar 25, 2026
Merged
Conversation
matthias-wende-frequenz
previously approved these changes
Mar 20, 2026
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Run Python in isolated mode (no adding . to PATH, etc.) to avoid any potential code execution issues, even when in some places we are already executing local code by design, it is better to have a safe default for everything. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Avoid unsafe shell word splitting and glob expansion that could be used for shell injection. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
We stopped creating a discussion per release a long time ago, so we don't need the permission anymore. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Request only for the permissions we need to use. In particular, explicitly request no permissions when none are needed, as the default gives at least contents write permission. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Introduces the security improvements, but also some old improvements that were not updated before. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
The merge-base changed after approval.
Contributor
Author
|
Rebased, needs a new approval @matthias-wende-frequenz |
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is to improve resilience and security. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
matthias-wende-frequenz
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the workflows security by: