Widen setuptools upper bound to < 81#401
Merged
llucax merged 1 commit intofrequenz-floss:v0.x.xfrom May 5, 2025
Merged
Conversation
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
There was a problem hiding this comment.
Pull Request Overview
This PR widens the upper bound for the setuptools dependency to allow version 80.x.
- Update setuptools version constraint in the api, dev-mypy, and dev-pylint dependency groups in pyproject.toml.
- Update RELEASE_NOTES.md to reflect the dependency change.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated setuptools and types-setuptools constraints to < 81 |
| RELEASE_NOTES.md | Updated release notes to mention the dependency change |
Comments suppressed due to low confidence (3)
pyproject.toml:60
- Ensure that widening the setuptools dependency to allow version 80.x is supported by the CI tests to avoid integration issues.
"setuptools >= 67.6.0, < 81",
pyproject.toml:91
- Verify that the types-setuptools update is compatible with the updated setuptools version to prevent type mismatches during usage.
"types-setuptools >= 67.6.0, < 81", # Should match the api dependency
pyproject.toml:104
- Confirm that the dependency update in this section is aligned with any integration or build scripts to mitigate potential compatibility issues.
"setuptools >= 67.6.0, < 81", # Should match the api dependency
Contributor
Author
|
Trivial, so I will force-merge after all tests passed if nobody approved. Will also release v0.13.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.