Fix setuptools dependency#387
Merged
llucax merged 1 commit intofrequenz-floss:v0.x.xfrom Apr 3, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dependency versions in the pyproject.toml file to ensure that the correct versions are used for both the API and development environments.
- The setuptools dependency in the API section is now allowed up to version 79.
- The types-setuptools dependency in the dev-mypy section is pinned to version 78.1.0 to match the build dependency.
Comments suppressed due to low confidence (2)
pyproject.toml:60
- Expanding the upper bound for the setuptools dependency might allow versions that have not been validated with the project; please verify compatibility for versions between 76 and 79.
"setuptools >= 67.6.0, < 79",
pyproject.toml:91
- Pinning types-setuptools to an exact version may lead to version drift if the build dependency updates; consider whether a version range might be more suitable while maintaining consistency with the build dependency.
"types-setuptools == 78.1.0", # Should match the build dependency
It looks like the deependency got a bit mixed up at some point, and `types-setuptools` dependency started getting widenned and the real optional dependency (for `api`) stopped being widenned. We'll probably need to keep an eye on dependabot to see if this was done by dependabot, but even if it is not, it is failing to widden the `setuptools` dependency for some reason. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
51287c7 to
a1fa91f
Compare
daniel-zullo-frequenz
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the deependency got a bit mixed up at some point, and
types-setuptoolsdependency started getting widenned and the real optional dependency (forapi) stopped being widenned.We'll probably need to keep an eye on dependabot to see if this was done by dependabot, but even if it is not, it is failing to widden the
setuptoolsdependency for some reason.