Properly translate paths from the python package name#199
Merged
llucax merged 1 commit intofrequenz-floss:v0.x.xfrom Dec 19, 2023
Merged
Properly translate paths from the python package name#199llucax merged 1 commit intofrequenz-floss:v0.x.xfrom
llucax merged 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
Marenz
previously approved these changes
Dec 19, 2023
Contributor
Author
|
Needs a new approval because of the rebase. |
When the `package_name` is changed from the default, we need to make sure we adapt the paths in the generated project to match the new package name, otherwise those packages will not be found. With this general approach, we can also remove the special case for `lib` projects, as it is now handled by the general case. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Marenz
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
package_nameis changed from the default, we need to make sure we adapt the paths in the generated project to match the new package name, otherwise those packages will not be found.With this general approach, we can also remove the special case for
libprojects, as it is now handled by the general case.Fix #198.