Skip to content

Unabbreviate THD in the Metric enum#209

Merged
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom
tiyash-basu-frequenz:thd_metric
Mar 22, 2024
Merged

Unabbreviate THD in the Metric enum#209
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom
tiyash-basu-frequenz:thd_metric

Conversation

@tiyash-basu-frequenz
Copy link
Copy Markdown
Contributor

@tiyash-basu-frequenz tiyash-basu-frequenz commented Mar 22, 2024

Metrics for Total Harmonic Distortion have been un-abbreviated:

  • METRIC_AC_THD_CURRENT -> METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT
  • METRIC_AC_THD_CURRENT_PHASE_[1|2|3] -> METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_[1|2|3]

Closes #177

@tiyash-basu-frequenz tiyash-basu-frequenz requested a review from a team as a code owner March 22, 2024 16:48
@github-actions github-actions Bot added part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files labels Mar 22, 2024
@tiyash-basu-frequenz tiyash-basu-frequenz self-assigned this Mar 22, 2024
Metrics for Total Harmonic Distortion have been un-abbreviated:
- `METRIC_AC_THD_CURRENT` -> `METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT`
- `METRIC_AC_THD_CURRENT_PHASE_[1|2|3]` -> `METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_[1|2|3]`

Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
Copy link
Copy Markdown

@nhatcher-frequenz nhatcher-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiyash-basu-frequenz tiyash-basu-frequenz added this pull request to the merge queue Mar 22, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 3a396c0 Mar 22, 2024
@tiyash-basu-frequenz tiyash-basu-frequenz deleted the thd_metric branch March 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Un-abbreviate THD in the Metric enum

2 participants