Skip to content

Rollup updates, enable auto dependabot merging#61

Merged
jssblck merged 4 commits intomainfrom
rollup-updates
Mar 20, 2025
Merged

Rollup updates, enable auto dependabot merging#61
jssblck merged 4 commits intomainfrom
rollup-updates

Conversation

@jssblck
Copy link
Contributor

@jssblck jssblck commented Feb 7, 2025

Overview

Rolls up outdated packages.

In addition:

  • Enables dependabot for node dependencies
  • Enables auto merging of dep update PRs that pass tests

Checklist

  • If I changed code, I ran yarn build and committed resulting changes.
  • I added an example exercising this PRs functionality to .github/workflows/test.yml or explained why it doesn't make sense to do so.

@jssblck jssblck requested a review from a team as a code owner February 7, 2025 20:03
@jssblck jssblck requested review from csasarak and removed request for a team February 7, 2025 20:03
Base automatically changed from mikeee/upgrade-node to main March 20, 2025 23:33
@jssblck jssblck enabled auto-merge (squash) March 20, 2025 23:39
@jssblck jssblck merged commit c0a7d01 into main Mar 20, 2025
2 checks passed
@jssblck jssblck deleted the rollup-updates branch March 20, 2025 23:40
@pieterocp
Copy link
Contributor

What if dependabot is suggesting a hijacked 3rd party dependency?

Am I correct in the assumption that it'd be merged without a human reviewing the changes?

@jssblck
Copy link
Contributor Author

jssblck commented Apr 1, 2025

What if dependabot is suggesting a hijacked 3rd party dependency?

Am I correct in the assumption that it'd be merged without a human reviewing the changes?

Hey @pieterocp! Good point- we do this for some other internal repositories since we have FOSSA checking them for vulnerability issues, but after discussing internally we agree this isn't a good fit for the GitHub Action.

The good(?) news is no significant upgrades have been performed automatically, so we'll double check the few that have and proceed from there manually.

Thanks for the nudge here, we appreciate it!

@pieterocp
Copy link
Contributor

No worries boss, it's probably fine but in the world where contributors can give the reins over to a "Jia Tan" or have an account compromised, better be careful.

It's a bit droll but an action can wait a bit, assuming that there's no security implications from the underlying libraries being used.

@jssblck
Copy link
Contributor Author

jssblck commented Apr 1, 2025

Yep, our thoughts exactly!

@spatten spatten mentioned this pull request Apr 1, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants